GH Issue 1257: Check for duplicates among field names, import aliases, and parent import aliases - #3128
Open
labkey-susanh wants to merge 5 commits into
Open
GH Issue 1257: Check for duplicates among field names, import aliases, and parent import aliases#3128labkey-susanh wants to merge 5 commits into
labkey-susanh wants to merge 5 commits into
Conversation
…, and parent import aliases
…le to all domains and tap into domain designer error messaging
labkey-danield
approved these changes
Jul 28, 2026
cnathe
reviewed
Jul 29, 2026
| updatePage.getFieldsPanel().addField("DupeAliasCheck") | ||
| .setImportAliases(GOOD_PARENT_NAME); | ||
| errors = updatePage.clickSaveExpectingErrors(); | ||
| errorMsgExpectedTxt = "Field DupeAliasCheck has an import alias " + GOOD_PARENT_NAME + " that conflicts with a parent alias header."; |
Contributor
There was a problem hiding this comment.
any reason we need to add some checks for the other cases here like having multiple fields that have the same import alias or having an import alias that matches a parent alias? Or maybe some of that could be covered with junit tests (not sure what our validation coverage looks like there for domains).
Contributor
Author
There was a problem hiding this comment.
I didn't include that here because this test class is specifically for SampleTypeParentColumnTest. So, tests aren't completely done for this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1257:
Related Pull Requests
Changes